Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@michellemv
Copy link
Contributor

Should fix issue #26

node:slim docker image has been updated to Node v15. So it's either use v14 which gets my vote as it is the LTS version or regenerate the package-lock.json file with Node 15 (assumed alternate fix).

@michellemv michellemv changed the title Use v14 LTS docker image to fix issues since v15 which is not LTS and the node:slim image has been upgraded to fix: Use v14 LTS docker image to fix issues since v15 which is not LTS and the node:slim image has been upgraded to Nov 3, 2020
@michellemv
Copy link
Contributor Author

I have just tested this by pointing our repo at my fork + fix branch, it works :)

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@gr2m gr2m merged commit b84d8ba into wip:master Nov 3, 2020
@michellemv michellemv deleted the fix/use-node-v14-docker-image branch November 3, 2020 16:35
@michellemv
Copy link
Contributor Author

@gr2m No problem! Can you update the version tag please?

@gr2m
Copy link
Contributor

gr2m commented Nov 3, 2020

I'm looking into it right now. It should have all been automated, but it's all so old, I'm updating it all to the latest right now and will release a new version shortly

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

πŸŽ‰ This PR is included in version 1.1.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

@gr2m
Copy link
Contributor

gr2m commented Nov 3, 2020

releases are now automated and are continuously pushed to the v1 branch. So you can do

- uses wip/action@v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants