-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
i18n(de): tutorial #12502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
i18n(de): tutorial #12502
Conversation
* Create index in German.mdx * Apply suggestions from code review Co-authored-by: Because789 <[email protected]> * fix description --------- Co-authored-by: Because789 <[email protected]> Co-authored-by: Yan <[email protected]>
* i18n(de): add 1-setup to german blog tutorial Adding German translation to Blog tutorial. * Apply suggestions from code review Implement feedback from review. Co-authored-by: Because789 <[email protected]> * Fehlermeldung im Original Korrektur nach Feedback. * Update src/content/docs/de/tutorial/1-setup/1.mdx Co-authored-by: Because789 <[email protected]> --------- Co-authored-by: Because789 <[email protected]> Co-authored-by: Yan <[email protected]>
* add `3-components/index` * Update index.mdx
* add `3-components/1` * fixing typos round 1 * Update src/content/docs/de/tutorial/3-components/1.mdx Co-authored-by: Timon Jurschitsch <[email protected]> --------- Co-authored-by: Timon Jurschitsch <[email protected]> Co-authored-by: Yan <[email protected]>
Co-authored-by: Max <[email protected]>
* add translation * first batch of typos * Update src/content/docs/de/tutorial/3-components/3.mdx Co-authored-by: Timon Jurschitsch <[email protected]> --------- Co-authored-by: Timon Jurschitsch <[email protected]>
* add `3-components/2.mdx` * fix first batch of typos --------- Co-authored-by: Yan <[email protected]>
Co-authored-by: Yan <[email protected]>
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
randomguy-2650
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve reviewed this PR and changed some formatting so it is more consistent with other tutorial‐related PRs being translated to German.
But what I’ve noticed is that there’s lots of inconsistency on which term to use. Maybe once all tutorial pages are done being translated, they should all be reviewed so it uses a consistent writing style.
This comment was marked as duplicate.
This comment was marked as duplicate.
randomguy-2650
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed something again to replace the “incorrect” quotes with the „correct ones“.
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]> Co-authored-by: Yan <[email protected]>
randomguy-2650
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, mostly on inconsistency.
Co-authored-by: randomguy-2650 <[email protected]> Co-authored-by: Felix Schneider <[email protected]>
trueberryless
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some link fixes since German translations got removed in #12483
Co-authored-by: randomguy-2650 <[email protected]> Co-authored-by: Felix Schneider <[email protected]>
randomguy-2650
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments that improves consistency with #12503 and translates some tags.
We do have to decide though, whether or not we should capitalise nouns in them.
Ich habe einige Kommentare gestellt, dass die Konsistenz mit #12503 verbessert und übersetzt einige Tags.
Wir müssen aber entscheiden, ob wir die Nomen/Substantive in den Tags großschreiben sollen.
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
randomguy-2650
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just consistency fixes. ✨
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: Felix Schneider <[email protected]> Co-authored-by: Louis Escher <[email protected]> Co-authored-by: Yan <[email protected]>
Co-authored-by: Yan <[email protected]> Co-authored-by: Felix Schneider <[email protected]> Co-authored-by: Louis Escher <[email protected]>
randomguy-2650
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This took absolutely forever to review, but these are hopefully the final consistency comments for the tutorial.
| **Änderung vornehmen** | ||
| Im Datei-Bereich solltest du `src/pages/index.astro` sehen. Klicke darauf und folge [„Schreibe deine erste Zeile Astro“](/de/tutorial/1-setup/3/), um diese Datei zu ändern. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is an example of that, see the previous comment for more information.
I know this is part is commented out, I just want to point out that other mentions use quotes.
| <MultipleChoice> | ||
| <Option>params</Option> | ||
| <Option>dynamic routing</Option> | ||
| <Option isCorrect>`getStaticPaths()`</Option> | ||
| <Option>props</Option> | ||
| </MultipleChoice> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might just be me, but I’m not sure why these aren’t translated.
I have noticed this long ago, but never pointed it out, so might as well do it now.
They also have to be translated for the other questions if you decide to translate them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another comment for you to chime in on @trueberryless
| --- | ||
| type: tutorial | ||
| unitTitle: Erstelle und gestalte mit Astro-Komponenten | ||
| title: 'Check-in: Lektion 3 – Komponenten' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| title: 'Check-in: Lektion 3 – Komponenten' | |
| title: 'Wissenscheck: Lektion 3 – Komponenten' |
Not sure if we should translate this… but if we should, I have a few suggestions:
- Wissenscheck
- Selbstcheck
- Lernkontrolle
- Kontrolle
- Überprüfung
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like "Wissenscheck"! @trueberryless thoughts?
Co-authored-by: randomguy-2650 <[email protected]>
Description (required)
Translate the whole tutorial into the German language
Related issues & labels (optional)
For a list of all remaining To-Do's, see this comment