-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: update cloudflare docs #12603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update cloudflare docs #12603
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
…hange their config and remove assets ignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for taking care of this @OliverSpeir and @florian-lefebvre !
One comment about the 404 section, and someone needs to figure out how to make Yan's change, but otherwise, good to go!
Co-authored-by: Sarah Rainsberger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's my final boss
Co-authored-by: Yan <[email protected]>
Co-authored-by: Yan <[email protected]>
Co-authored-by: Yan <[email protected]>
Co-authored-by: Yan <[email protected]>
Co-authored-by: Yan <[email protected]>
Co-authored-by: Yan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this is okay if I have two more nits after our final boss. 😁
Except those, LGTM!
Co-authored-by: Armand Philippot <[email protected]>
Description (required)
Related issues & labels (optional)
For Astro version:
5.15. See astro PR #14564.