Fix failing test with invalid port by adding popper handling of the error #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror. Will also handle other reference errors more gracefully. Closes wjdp#127.
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
- Coverage 86.58% 83.96% -2.63%
==========================================
Files 20 20
Lines 1066 1110 +44
==========================================
+ Hits 923 932 +9
- Misses 136 166 +30
- Partials 7 12 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will also handle other reference errors more gracefully.
Closes #127.