Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@RobinMeis
Copy link
Contributor

Solved issue #4076 by allowing lower values for touch threshold

@blazoncek
Copy link
Collaborator

Once @DedeHai gets back from vacation I hope he'll review and approve.

Copy link
Collaborator

@DedeHai DedeHai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to test, may lead to ghost detections

@RobinMeis
Copy link
Contributor Author

Need to test, may lead to ghost detections

For me it doesn't but shouldn't be a too big issue as you already can get ghost detections on ESP32-Wroom with inappropriate settings.

@DedeHai
Copy link
Collaborator

DedeHai commented Aug 18, 2024

I tested the change, low values lead to ghost detections but that is probably ok, I did not notice any crashes in my tests (tested on S2).
@RobinMeis your PR is missing changes to the second interrupt attachment here:
https://github.com/Aircoookie/WLED/blob/f6c47ac19cd9fc2b6b2861289b86f2ef963a329a/wled00/set.cpp#L292

apart from that I am ok with removing the 256 as a minimum base value.

@RobinMeis
Copy link
Contributor Author

I have fixed this. For me, I also get ghost detections for very low values but didn't get any ghost detections within the last two weeks on two lamps with reasonable values.

@DedeHai
Copy link
Collaborator

DedeHai commented Aug 18, 2024

looks good, gets my approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants