This repository was archived by the owner on Feb 20, 2025. It is now read-only.
Improve process termination on cleanDanglingUnityFiles #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azurelol
approved these changes
Dec 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relying on the output of
processHandle.destroy()is only enough to know if the process received the TERM signal, not if it did anything with it. We now check if the process is actually terminated (5s timeout) before pulling the big guns and sending a KILL.Also add lots of logs for people to know exactly whats going on here.
Changes
terminateProcessoption onclearDanglingUnityFilestask wasn't terminating frozen processesclearDanglingUnityFiles