Add windows support with blessed #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 11, 2020 20:46
Contributor
Author
|
I don't understand why the check fails, could you help me? |
Owner
|
This line fails: > t_color.normal = u'\x1b[0;10m'
E AttributeError: can't set attributewhich is a workaround for #32. |
Contributor
Author
|
"fixed" |
wookayin
reviewed
Jan 14, 2020
gpustat/core.py
Outdated
| " be used at the same time") | ||
|
|
||
| if force_color: | ||
| if force_color and not self.is_windows(): |
Owner
There was a problem hiding this comment.
Why checking windows here? On windows, the --color flag should also work.
Contributor
Author
There was a problem hiding this comment.
you're right! my bad
wookayin
added a commit
that referenced
this pull request
Jan 16, 2020
Owner
|
I am trying to add a travis CI test. Do you have any idea about why the test fails? |
Contributor
Author
No idea! For me the test works fine. The tests worked before, didn't they? |
Owner
|
Not on windows. |
Contributor
Author
|
Mhh. seriously no clue. The tests run fine on my Windows machine, also the command |
Owner
|
No worries, I will take care of them. FYI I reported an issue jquast/blessed#126. |
wookayin
added a commit
that referenced
this pull request
Feb 2, 2020
- To prevent blinking cursors, do not re-store cursor locations - Workaround sgr0 character issues (#32) again - Misc: various style cleanups
This was referenced Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've re-added support for Windows and fixed the broken imports/code
Main changes:
blessingtoblessed. Essentially the same library, yet also works on Windowssignal.SIGPIPEon Windows (not available). Don't know what that line's adding anyway.localeformatting stringNone, reportNoneSome remarks: On Windows (and partially on Linux), newer NVIDIA drivers can only report the memory usage of individual processes if the card is in TCC (dedicated) mode, that means no monitor is attached to them.
It might be handy to report this in the README