Support python3 in --json option #21
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is an attempt to avoid `ImportError: No module named six` which occurs when installing gpustat, which occurs because of (yet not installed & to-be-installed) six module
Stonesjtu
reviewed
Aug 23, 2017
gpustat.py
Outdated
| import json | ||
|
|
||
| __version__ = '0.4.0.dev' | ||
| import six |
Collaborator
There was a problem hiding this comment.
You can simply move this import into function jsonify, thus the lazy import should not cause the problem in setup.py.
Author
There was a problem hiding this comment.
Thank you for your advice!
I now use lazy import in afbd117 .
This reverts commit 8aaf01b.
Owner
|
Thank you for your contribution. I admit that the current release (0.3.1) has the bug on Python 3, but a new changeset is superseding this. |
wookayin
added a commit
that referenced
this pull request
Sep 17, 2017
Owner
|
Released v0.3.2 (see the corresponding commit). On master branch toward v0.4, it is already fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--jsonoption does not work when using python3, asiteritems()is not available in python3.Thus, I add
sixmodule so that both python2 and python3 can use--jsonoption.Also, I had to directly write version information in
setup.pyas importinggpustat.pyinsetup.pycauses an installation error. (setup.pytries and fails to import yet-not-installedsix)