Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add St John the Baptist day for Catalonian calendar #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add St John the Baptist day for Catalonian calendar #643

wants to merge 2 commits into from

Conversation

@lozlow
Copy link
Contributor

@lozlow lozlow commented Apr 12, 2021 •
edited
Loading

Adds missing public holiday for Catalonian calendar, see here for reference: https://www.timeanddate.com/holidays/spain/sant-joan

  • Tests with a significant number of years to be tested for your calendar.
  • Changelog amended with a mention describing your changes. Note Please do NOT change the version number here. It's the project maintainers' duty.

@KidkArolis
Copy link
Contributor

Another source, the Barcelona City Council site showing that June 24th is a public holiday in Catalonia region: https://ajuntament.barcelona.cat/calendarifestius/en/

@brunobord
Copy link
Member

Planning to merge this and make a bugfix release today. Stay tuned!

@brunobord brunobord mentioned this pull request Apr 23, 2021
Merged
2 tasks
brunobord added a commit that referenced this pull request Apr 23, 2021
@brunobord
v15.2.0
fbe560f 
Essentially a bugfix release.

- Fixed Cuiaba City calendar (Brazil), adding Easter Sunday, Corpus Christi and Good Friday, thx @leogregianin (#642).
- Fix Catalonian calendar: add missing St John the Baptist public holiday, thx @lozlow (#643).
@brunobord brunobord mentioned this pull request Apr 23, 2021
Merged
14 tasks
@brunobord
Copy link
Member

version 15.2.0 was released and publish on PyPI, happy upgrading!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lozlow @KidkArolis @brunobord