Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "Refresh wp-settings-cli.php to reflect changes to Core wp-settings.php" #5302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Fix cli cache prune command
merged 1 commit into from
Oct 31, 2019
Merged

Revert "Refresh wp-settings-cli.php to reflect changes to Core wp-settings.php" #5302

merged 1 commit into from
Oct 31, 2019

Conversation

@schlessera
Copy link
Member

Reverts #5300, as the wp-settings-cli.php is not actually being used for any WordPress Core version after 4.6-alpha-37575:

wp-cli/php/WP_CLI/Runner.php

Lines 1228 to 1241 in 538d9be

if ( Utils\wp_version_compare( '4.6-alpha-37575', '>=' ) ) {
if ( $this->cmd_starts_with( array( 'help' ) ) ) {
// Hack: define `WP_DEBUG` and `WP_DEBUG_DISPLAY` to get `wpdb::bail()` to `wp_die()`.
if ( ! defined( 'WP_DEBUG' ) ) {
define( 'WP_DEBUG', true );
}
if ( ! defined( 'WP_DEBUG_DISPLAY' ) ) {
define( 'WP_DEBUG_DISPLAY', true );
}
}
require ABSPATH . 'wp-settings.php';
} else {
require WP_CLI_ROOT . '/php/wp-settings-cli.php';
}

@schlessera schlessera requested a review from a team as a code owner October 31, 2019 02:35
@schlessera schlessera added this to the 2.4.0 milestone Oct 31, 2019
@schlessera schlessera merged commit bcda63e into master Oct 31, 2019
@schlessera schlessera deleted the revert-5300-refresh-wp-settings-cli-file branch October 31, 2019 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

scope:framework

Projects

None yet

Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

1 participant

@schlessera