Feature/fao global #3400
Merged
Feature/fao global #3400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edbrett
suggested changes
May 9, 2018
Contributor
edbrett
left a comment
There was a problem hiding this comment.
Great. One small change to make code simpler.
| dispatch(setWidgetData({ data: hasCountryData ? data : {}, widget })); | ||
| dispatch( | ||
| setWidgetData({ | ||
| data: hasCountryData || params.type === 'global' ? data : {}, |
Contributor
There was a problem hiding this comment.
Why not remove the country dependancy from the check above instead? So that you only check for data.length
edbrett
approved these changes
May 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates FAO reforestation and deforestation ranked widgets to be compatible with the global dashboard.
Notes