Feature/global gain ranked #3402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edbrett
suggested changes
May 9, 2018
| if (gainData && gainData.length) { | ||
| mappedData = gainData.map(item => { | ||
| const gain = item.gain ? item.gain : 0; | ||
| const extent = item.value ? item.value : 0; |
Contributor
There was a problem hiding this comment.
you can use item.value || 0
| const locationData = | ||
| currentLocation && data.find(l => l.id === currentLocation.value); | ||
| const gain = locationData && locationData.gain; | ||
| currentLabel && data.find(l => l.id === currentLabel.value); |
Contributor
There was a problem hiding this comment.
currentlLabel is a string not an object. This should fail. Use currentLocation if you need the value
edbrett
suggested changes
May 11, 2018
| } = sentences; | ||
| const locationData = currentLabel && data.find(l => l.id === currentLabel); | ||
| const locationData = | ||
| currentLabel && data.find(l => l.id === currentLocation.value); |
Contributor
There was a problem hiding this comment.
you are using currentLabel for checking. This should be the same as the comparison at the end of the line.
edbrett
approved these changes
May 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Prepares the Ranked Gain widget in the face of impending globalisation.
The bonus mayo on this pr-sandwich is that it also fixes a hither-to-unseen bug in the relative gain calculations, which also helped slim down the code in the
action.jsfile.Notes
As always, please test.
This widget will also likely need pagination on the global page in the future.