Fix/search coords not centering #3663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfrico
approved these changes
Nov 28, 2018
Contributor
dfrico
left a comment
There was a problem hiding this comment.
Works as expected! 👍
Note: The parsing to float, is it because it wasn't considering lat and long decimals? Seems to be fine now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In the Search section of the map menu, when entering coordinates or decimal degrees and submitting the map was updating the center position of the map during the movement to the new desired location. This was causing the center values to be incorrect, and also requiring the user to continue submitting until they reached the correct location. See the pitoval task to access the videos: https://www.pivotaltracker.com/story/show/162083518.
Solution: use the leaflet event
moveendinstead ofmoveto prevent updating the center early. Additionally floats were being parsed into floats (due to my own incompetence). Now float are floating correctly.Testing