Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dfrico
Copy link
Contributor

@dfrico dfrico commented Dec 26, 2018

Overview

Pie chart: Emissions in plantations vs natural forests. Feats a donut plot showing CO2 emissions of Natural forest and Plantations.

image

@dfrico dfrico requested a review from edbrett December 26, 2018 12:25
@dfrico dfrico added the WIP Any PR that should not be merged to develop label Dec 26, 2018
@dfrico
Copy link
Contributor Author

dfrico commented Dec 26, 2018

Needs more info related to config file, specifically about the metaKey, layers, maybe more sentences (in case the percentage used is 0%), and years dropdowns in settings.

@edbrett edbrett added the staging Any PR expected to be kept on staging label Jan 9, 2019
@benlaken
Copy link
Contributor

  • Title: "Emissions from biomass loss in Natural Forests vs plantations in "
  • We should not have a global version of this widget, as it needs to be limited to countries with plantations data. (i.e. same restrictions as the widget 'Forest loss in Natural Forest in '.)
  • The first year shown should be 2013 (same as the other plantation widget previously mentioned). The last year should be the last year of biomass loss data returned - 2017 currently. (Currently the dynamic sentence states the data covers a period of 2010 to 2018.)
  • Years should be selectable in the settings menu (see example 'Emissions from biomass loss in ').
  • Units should be selectable in settings menu, changing between CO₂ and Carbon.
    --> check widget 'Emissions from Biomass Loss in ': to see how to change between CO₂ and Carbon units.
  • CO₂ should appear as sub-script (₂), not as CO2.
  • Canopy density should be selectable
  • Units on widget legend need to be changed: they are currently in ha instead of tonnes (t). Note, the units in the dynamic sentence are correct.
  • Associated dataset layer should be biomass loss (not tree cover). The layer ID for this is: b32a2f15-25e8-4ecc-98e0-68782ab1c0fe
  • Associated metadata key for biomass loss data is tree_biomass_loss
  • Settings button currently not working

@benlaken benlaken self-requested a review January 10, 2019 09:38
Copy link
Contributor

@benlaken benlaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes needed - check my above comment!

Copy link
Contributor

@benlaken benlaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dfrico dfrico added develop Any PR that is ready to be merged to develop and removed WIP Any PR that should not be merged to develop labels Jan 16, 2019
@edbrett edbrett merged commit 14f99b5 into develop Jan 17, 2019
@edbrett edbrett deleted the feature/donut-plot branch January 17, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

develop Any PR that is ready to be merged to develop staging Any PR expected to be kept on staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants