Feature/landsat tiles refactor #3708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edbrett
suggested changes
Feb 24, 2019
Contributor
edbrett
left a comment
There was a problem hiding this comment.
Thanks for sorting this. I think there is still some code you can remove to clean up.
| basemap, | ||
| year: basemap.year, | ||
| zoom | ||
| if ( |
Contributor
There was a problem hiding this comment.
If the zoom is now part of the url and is fetched from the service I don't think this is still needed?
edbrett
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR uses the new landsat endpoint to fetch the tiles instead of manually calculating it for zoom values greater than 11.