Dev mlst output update #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbigailShockey
requested changes
Jul 17, 2025
Collaborator
AbigailShockey
left a comment
There was a problem hiding this comment.
Validation data set needs to be updated. Please update the validation test data set and resubmit for review
AbigailShockey
requested changes
Jul 17, 2025
Collaborator
AbigailShockey
left a comment
There was a problem hiding this comment.
Waiting on CDC to confirm what they want in cases of no MLST scheme predicted. Additionally, there should be a space between genus and species, per instruction in original request
MLST<WGS result>_<scheme used>_<organism name>
AbigailShockey
approved these changes
Jul 23, 2025
Collaborator
AbigailShockey
left a comment
There was a problem hiding this comment.
Updated version to 1.6.0 in nextflow.config file since this is new functionality. The new formatting should be noted in the release notes
evagunawan
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
MLST Schemereported asMLST<WGS result>_<scheme used>_<organism name>.