Stop failing the run and let the user decide how to proceed #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 86.74% 86.74%
=======================================
Files 5 5
Lines 83 83
Branches 11 11
=======================================
Hits 72 72
Partials 11 11
Continue to review full report at Codecov.
|
|
is this getting merged soon ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was brought up in #124. The only time we should fail the run is when the user lacks the required permissions to trigger this step so this removes the calls to
setFailed()and replaces them withdebug().To tell if this step was a success or not you can check the out params like so:
A subsequent PR will add a new
has-commandout parameter that's meant for these types of checks.This is a breaking change for v1 so it'll be released as v2.