Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix unit test failed #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 11, 2024
Merged

Fix unit test failed #19

merged 3 commits into from
Dec 11, 2024

Conversation

@wanghaochen2024
Copy link
Contributor

@wanghaochen2024 wanghaochen2024 commented Dec 8, 2024

PR Details

Fix GitHub action failed

Description

Update GitHub action config

Related Issue

#18

Motivation and Context

Using macos-13 instead of macos-lasted to avoid test arm64

How Has This Been Tested

Run GitHub action pipeline

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 8, 2024
@codecov
Copy link

codecov bot commented Dec 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (9ad904a) to head (d73add7).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   99.47%   99.55%   +0.08%     
==========================================
  Files           1        1              
  Lines         378      450      +72     
==========================================
+ Hits          376      448      +72     
  Partials        2        2
Flag Coverage Δ
unittests 99.55% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xuri
xuri approved these changes Dec 11, 2024
View reviewed changes
Copy link
Owner

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit c4e9920 into xuri:master Dec 11, 2024
39 checks passed
@wanghaochen2024 wanghaochen2024 deleted the gh-action branch December 13, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xuri xuri xuri approved these changes

Assignees

No one assigned

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wanghaochen2024 @xuri