Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[PR]: Regridding nan update (dask part only)#634

Merged
tomvothecoder merged 1 commit intomainfrom
regrid_nan_update_part2only
Apr 2, 2024
Merged

[PR]: Regridding nan update (dask part only)#634
tomvothecoder merged 1 commit intomainfrom
regrid_nan_update_part2only

Conversation

@lee1043
Copy link
Collaborator

@lee1043 lee1043 commented Apr 2, 2024 •
edited
Loading

Description

To fast track issue resolve for #615, a part of PR #613 is applied in this PR which is applying .values instead of .data for dask case following changes made by @tomvothecoder and @jasonb5

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@lee1043 lee1043 requested review from jasonb5 and tomvothecoder April 2, 2024 06:41
@codecov
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5de4d7f) to head (8c18727).

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #634   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1588      1588           
=========================================
  Hits          1588      1588

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lee1043
Copy link
Collaborator Author

lee1043 commented Apr 2, 2024

@tomvothecoder @jasonb5 sorry for the duplicating, but as some of my PMP workflow is highly influenced by the issue #615, I wanted repair for that part to be fast tracked, because I guess the new issue found in PR #613 could delay the merging of the PR than anticipated.

@lee1043 lee1043 changed the title Regridding nan update (dask part only) [PR]: Regridding nan update (dask part only) Apr 2, 2024
@lee1043 lee1043 marked this pull request as ready for review April 2, 2024 06:46
@tomvothecoder tomvothecoder mentioned this pull request Apr 2, 2024
Merged
9 tasks
@tomvothecoder
Copy link
Collaborator

tomvothecoder commented Apr 2, 2024

Thanks @lee1043. I am giving us another week so that @jasonb5 can try to get PR #613 done. If it's not done by then, we can merge this PR and move forward with releasing v0.7.0.

jasonb5
jasonb5 approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@jasonb5 jasonb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomvothecoder
Copy link
Collaborator

tomvothecoder commented Apr 2, 2024

I'll go ahead and merge this.

@tomvothecoder tomvothecoder merged commit a9b6c5d into main Apr 2, 2024
@tomvothecoder tomvothecoder deleted the regrid_nan_update_part2only branch April 2, 2024 16:58
@lee1043
Copy link
Collaborator Author

lee1043 commented Apr 2, 2024

@tomvothecoder @jasonb5 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonb5 jasonb5 jasonb5 approved these changes

@tomvothecoder tomvothecoder Awaiting requested review from tomvothecoder

Assignees

No one assigned

Labels

None yet

Projects

xCDAT Development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: regrid2 with open_mfdataset

3 participants

@lee1043 @tomvothecoder @jasonb5

Comments