Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update get_bounds() to support mappable non-CF axes using "bounds" attr #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tomvothecoder merged 8 commits into from
Oct 8, 2024
Merged

Update get_bounds() to support mappable non-CF axes using "bounds" attr #708

tomvothecoder merged 8 commits into from
Oct 8, 2024

Conversation

@tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Oct 7, 2024 •
edited
Loading

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder changed the title Update get_bounds() to return bounds for mappable non-CF axis using "bounds" attr Update get_bounds() to support mappable non-CF axis using "bounds" attr Oct 7, 2024
@github-actions github-actions bot added the type: bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Oct 7, 2024
@tomvothecoder tomvothecoder changed the title Update get_bounds() to support mappable non-CF axis using "bounds" attr Update get_bounds() to support mappable non-CF axes using "bounds" attr Oct 7, 2024
@github-actions github-actions bot added the type: docs Updates to documentation label Oct 8, 2024
@tomvothecoder tomvothecoder self-assigned this Oct 8, 2024
@codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e3dda64) to head (338d71f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #708   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1546      1555    +9     
=========================================
+ Hits          1546      1555    +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tomvothecoder
tomvothecoder commented Oct 8, 2024
View reviewed changes
@tomvothecoder tomvothecoder mentioned this pull request Oct 8, 2024
Closed
@tomvothecoder tomvothecoder merged commit 96bc649 into main Oct 8, 2024
@tomvothecoder tomvothecoder deleted the bugfix/707-get-bounds branch October 8, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tomvothecoder tomvothecoder

Labels

type: bug Inconsistencies or issues which will cause an issue or problem for users or implementors. type: docs Updates to documentation

Projects

xCDAT Development
Status: Done

Milestone

FY25Q1 (10/01/24 - 12/31/24)

Development

Successfully merging this pull request may close these issues.

[Bug]: get_bounds() can't get bounds for non-CF axes without var_key argument

2 participants

@tomvothecoder