Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@the-black-eagle
Copy link
Contributor

…ters

Description

Due to the ffmpeg bump, the duration for the last chapter of an .m4b audiobook is no longer calculated. This PR fixes that.

Motivation and context

Rebased some other stuff to do with audiobooks in general that I am looking at, and noticed this issue.

How has this been tested?

Tested locally.

What is the effect on users?

Last chapter of an audiobook will have the correct duration.

Screenshots (if appropriate):

Before fix.
screenshot00115
screenshot00116

After fix.
screenshot00117
screenshot00118

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@the-black-eagle the-black-eagle added Type: Fix non-breaking change which fixes an issue Component: Music v21 Omega labels Feb 18, 2024
@the-black-eagle the-black-eagle added this to the Omega 21.0 RC1 milestone Feb 18, 2024
@fuzzard fuzzard merged commit 213cb31 into xbmc:master Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Music Type: Fix non-breaking change which fixes an issue v21 Omega

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants