-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
MacOS: Implement hotkeycontroller to fix exclusive mediakey usage #24765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kambala-decapitator
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good in general, just some minor stuff to improve.
Runtime tested: works great!
c369b10 to
69f8864
Compare
Member
Author
|
jenkins build this please |
kambala-decapitator
approved these changes
Feb 28, 2024
kambala-decapitator
approved these changes
Feb 29, 2024
Contributor
kambala-decapitator
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you also need to re-run formatter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements a hotkeycontroller which is able to receive announcements from GUI and Player and enable or disable the exclusive mediakey tap only in particular circumstances - reducing the risk of affecting other apps.
Removed the media key processing from windowing since even if Kodi is running headless (and playing audio for example) it should still be able to trap media keys.
Motivation and context
Fix #24579
How has this been tested?
Runtime tested on macOS checking that if the kodi app is key (has focus) media keys work without opening the music app. if a file is not playing and Kodi is not focused mediakeys do not get piped to Kodi. If a file is playing and kodi is not focused, Kodi responds to media keys.
What is the effect on users?
Media keys should now work without affecting the music app.
Screenshots (if appropriate):
Types of change
Checklist: