Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@enen92
Copy link
Member

@enen92 enen92 commented Feb 26, 2024

Description

This implements a hotkeycontroller which is able to receive announcements from GUI and Player and enable or disable the exclusive mediakey tap only in particular circumstances - reducing the risk of affecting other apps.
Removed the media key processing from windowing since even if Kodi is running headless (and playing audio for example) it should still be able to trap media keys.

Motivation and context

Fix #24579

How has this been tested?

Runtime tested on macOS checking that if the kodi app is key (has focus) media keys work without opening the music app. if a file is not playing and Kodi is not focused mediakeys do not get piped to Kodi. If a file is playing and kodi is not focused, Kodi responds to media keys.

What is the effect on users?

Media keys should now work without affecting the music app.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@enen92 enen92 added Type: Fix non-breaking change which fixes an issue Platform: macOS v21 Omega labels Feb 26, 2024
@enen92 enen92 added this to the Omega 21.0 RC1 milestone Feb 26, 2024
Copy link
Contributor

@kambala-decapitator kambala-decapitator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good in general, just some minor stuff to improve.

Runtime tested: works great!

@enen92 enen92 force-pushed the tap branch 2 times, most recently from c369b10 to 69f8864 Compare February 28, 2024 17:29
@enen92 enen92 closed this Feb 28, 2024
@enen92 enen92 reopened this Feb 28, 2024
@enen92
Copy link
Member Author

enen92 commented Feb 28, 2024

jenkins build this please

Copy link
Contributor

@kambala-decapitator kambala-decapitator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to re-run formatter

@enen92 enen92 closed this Feb 29, 2024
@enen92 enen92 reopened this Feb 29, 2024
@enen92 enen92 closed this Feb 29, 2024
@enen92 enen92 reopened this Feb 29, 2024
@enen92 enen92 closed this Feb 29, 2024
@enen92 enen92 reopened this Feb 29, 2024
@enen92 enen92 merged commit f476db1 into xbmc:master Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Platform: macOS Type: Fix non-breaking change which fixes an issue v21 Omega

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[macOS] play/pause system hotkey affects the system Music app

2 participants