Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@garbear
Copy link
Member

@garbear garbear commented Jul 3, 2023

Description

In #22856, I added the ability to set a peripheral's "appearance".

In the joystick add-on, when looking up the appearance, the full peripheral's properties are used. However, upon inspection in a debugger, I noticed that the joystick add-on saw mice and keyboards as UNKNOWN.

While no bugs currently arise do to the missing types, we should add them for future use by the add-on.

How has this been tested?

Included in my latest round of test builds: https://github.com/garbear/xbmc/releases

Tested in the debugger.

Before: When querying the apperaance of mice and keyboards, the joystick sees the peripheral's type as UNKNOWN.

After: The joystick sees the type of mice and keyboards correctly as MOUSE or KEYBOARD, respectively.

What is the effect on users?

None.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@garbear garbear added Type: Improvement non-breaking change which improves existing functionality Component: Input API change: Binary add-ons v21 Omega labels Jul 3, 2023
@garbear garbear added this to the Omega 21.0 Alpha 3 milestone Jul 3, 2023
@garbear garbear force-pushed the add-mouse-keyboard branch from 8ddb8e1 to 568f26d Compare July 3, 2023 01:11
@garbear garbear merged commit 5260bf0 into xbmc:master Jul 7, 2023
@garbear garbear deleted the add-mouse-keyboard branch July 7, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API change: Binary add-ons Component: Input Type: Improvement non-breaking change which improves existing functionality v21 Omega

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant