Peripheral API v3.0.1: Expose keyboard/mouse types to add-on #23468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #22856, I added the ability to set a peripheral's "appearance".
In the joystick add-on, when looking up the appearance, the full peripheral's properties are used. However, upon inspection in a debugger, I noticed that the joystick add-on saw mice and keyboards as UNKNOWN.
While no bugs currently arise do to the missing types, we should add them for future use by the add-on.
How has this been tested?
Included in my latest round of test builds: https://github.com/garbear/xbmc/releases
Tested in the debugger.
Before: When querying the apperaance of mice and keyboards, the joystick sees the peripheral's type as UNKNOWN.
After: The joystick sees the type of mice and keyboards correctly as MOUSE or KEYBOARD, respectively.
What is the effect on users?
None.
Types of change