Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.58%. Comparing base (f9f8edb) to head (be1479e).

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Open in StackBlitz

pnpm add https://pkg.pr.new/xeho91/js-ast/svelte-ast-print@113

commit: be1479e

Is there any reason this has not been released? I'm currently prototyping for the sv cli, and the separate print function would be largely beneficial for this. (My current idea is to drop a bunch of dependencies and do all manipulations based on the svelte compiler and this awesome project.)

Also, i did try to use the preview releases, but I always get this error

Cannot find module 'D:\svelte-cli-svelte-ast-print-mvp\node_modules\.pnpm\svelte-ast-build@https+++pk_57ca5000c720269d3d8eaee4126b0280\node_modules\svelte-ast-build\src\_shared' imported from D:\svelte-cli-svelte-ast-print-mvp\node_modules\.pnpm\svelte-ast-build@https+++pk_57ca5000c720269d3d8eaee4126b0280\node_modules\svelte-ast-build\src\script.js

But maybe i'm doing something wrong on my end.

RE @manuel3108

No, you're not doing anything wrong. Pardon my absent-mindedness. 🙏
What happened is that while I was experimenting around to improve the package, I did more than necessary. In the meantime, I started a new job, so my priorities completely shifted.

I did a quick clean-up of the current progress, but I need one or two more days to finish.
As for now, I've managed to bring into a state where svelte-ast-print doesn't depend on any WIP packages from this repo. However, I need a time to ensure it doesn't break anything else. And that's because, despite the tests passing successfully, it doesn't give me confidence enough to do it without manual verification that it doesn't break packages which depend on it - e.g. @storybook/addon-svelte-csf.

Hey thanks for the heads-up and invitation! This is absolutely non time critical, I'm not even sure if my idea will work out in the end. Take your time and enjoy your private live!

Thanks!

I think I'm getting closer to wrapping up. The latest release is in this comment.
Tomorrow I'll check if there are any issues with @storybook/addon-svelte-csf.

I'm also considering waiting until 30th April (Node.js v18 EOL), so there's no necessity to release two major versions in a short time.

Thanks for your work!

Looks like the published packages is basically empty. I think the build step is missing in the preview workflow.

In the meantime I tried linking everything together locally, and tried running the following code:

import { expect, test } from 'vitest';
import { parse } from 'svelte/compiler';
import { print } from 'svelte-ast-print';

test('svelte', () => {
    const code = `
    <script>
        console.log('asd');
    </script>

    <div><p>Asd</p></div>

    <style>
        p { color: red }
    </style>
    `;

    const ast = parse(code, { modern: true });

    const newCode = print(ast);

    expect(newCode).toMatchInlineSnapshot();
});

Currently I'm getting the following error:

 FAIL  parse-and-print.test.js > svelte
Error: Not implemented Root
 ❯ handle ../js-ast/node_modules/.pnpm/[email protected]/node_modules/esrap/src/handlers.js:53:9
 ❯ Module.print ../js-ast/node_modules/.pnpm/[email protected]/node_modules/esrap/src/index.js:44:2
 ❯ print_js ../js-ast/packages/svelte-ast-print/src/_internal/js.ts:15:5
 ❯ print ../js-ast/packages/svelte-ast-print/dist/lib.js:91:24
     89|         st.add(printSvelte(n, opts));
     90|     else
     91|         st.add(print_js(n, st.opts));
       |                        ^
     92|     return st.result;
     93| }
 ❯ parse-and-print.test.js:20:26

Looks like it's trying to pass the Root element down to esrap, which in this case has no idea how it should implement this unknown type. Which makes sense because

export function isSvelteOnlyNode(n: JS.BaseNode | SV.BaseNode): n is SvelteOnlyNode {
	return new Set([""]).has(n.type);
}

is basically false at all times.

LMK if i'm using the package wrong!