git xet migrate bugfixes #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2cfc595 to
2687f31
Compare
2687f31 to
9f9828f
Compare
assafvayner
reviewed
Jun 17, 2024
hoytak
commented
Jun 17, 2024
rust/gitxetcore/src/git_integration/repo_migration/migration.rs
Outdated
Show resolved
Hide resolved
hoytak
commented
Jun 17, 2024
rust/gitxetcore/src/git_integration/repo_migration/migration.rs
Outdated
Show resolved
Hide resolved
hoytak
commented
Jun 17, 2024
hoytak
commented
Jun 17, 2024
hoytak
commented
Jun 17, 2024
hoytak
commented
Jun 17, 2024
rust/gitxetcore/src/git_integration/repo_migration/migration.rs
Outdated
Show resolved
Hide resolved
seanses
reviewed
Jun 17, 2024
added 11 commits
June 17, 2024 11:08
added 16 commits
June 17, 2024 16:14
seanses
approved these changes
Jun 18, 2024
added 5 commits
June 17, 2024 20:16
… hoytak/240611-git-xet-migrate-port-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes many previously unknown issues with git xet repo migrate.
-> Notes were not migrated.
-> Tags were not correctly migrated.
-> Merge and cherry-pick commits were not properly tracked as such.
The logic to properly do all of this required rethinking the flow. The new design is MUCH better and more laid out, but is essentially a rewrite of all of it.