Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Load bigg data #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 8, 2023
Merged

Load bigg data #384

merged 12 commits into from
Jun 8, 2023

Conversation

@nwlandry
Copy link
Collaborator

@nwlandry nwlandry commented Jun 5, 2023

This addresses #376. This PR

  • Moves the json from url functions to the utilities and slims down the xgi_data module
  • Adds a bigg_data module.

@codecov
Copy link

codecov bot commented Jun 5, 2023 •
edited
Loading

Codecov Report

Patch coverage: 92.42% and project coverage change: -0.10 ⚠️

Comparison is base (5b2cc16) 91.11% compared to head (004c199) 91.02%.

❗ Current head 004c199 differs from pull request most recent head bd3c1da. Consider uploading reports for the commit bd3c1da to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
- Coverage   91.11%   91.02%   -0.10%     
==========================================
  Files          46       47       +1     
  Lines        3771     3878     +107     
==========================================
+ Hits         3436     3530      +94     
- Misses        335      348      +13
Impacted Files Coverage Δ
xgi/algorithms/centrality.py 97.39% <ø> (ø)
xgi/stats/dinodestats.py 82.35% <ø> (-0.99%) ⬇️
xgi/utils/utilities.py 93.05% <73.68%> (-6.95%) ⬇️
xgi/readwrite/__init__.py 100.00% <100.00%> (ø)
xgi/readwrite/bigg_data.py 100.00% <100.00%> (ø)
xgi/readwrite/xgi_data.py 100.00% <100.00%> (+6.00%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

leotrs
leotrs requested changes Jun 5, 2023
View reviewed changes
@nwlandry nwlandry marked this pull request as ready for review June 5, 2023 21:34
@nwlandry nwlandry requested a review from leotrs June 7, 2023 19:05
leotrs
leotrs reviewed Jun 7, 2023
View reviewed changes
@nwlandry nwlandry merged commit c36b9cd into main Jun 8, 2023
@nwlandry nwlandry deleted the load-bigg-data branch June 8, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leotrs leotrs leotrs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nwlandry @leotrs