Fix version switching #590
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #590 +/- ##
=======================================
Coverage 93.14% 93.14%
=======================================
Files 60 60
Lines 4506 4506
=======================================
Hits 4197 4197
Misses 309 309 ☔ View full report in Codecov by Sentry. |
| "image_light": "../../logo/logo.svg", | ||
| "image_dark": "../../logo/logo_white.svg", | ||
| }, | ||
| "navbar_start": ["navbar-logo", "navbar-version"], |
There was a problem hiding this comment.
is having the version on the left with the logo not redundant with having it displayed on the right in the switcher?
|
Not sure exactly what caused this but now the New release button says "dev" instead of the version number: |
|
Mmm. Good catch! Sorry about that. The only issue with putting the version in the version switcher is that you need to edit by hand, which is totally fine, but I was trying to be clever and have the website be completely "hands-free" so it would auto import the version, date, etc. but obviously there are some downsides. Happy to make a little PR removing the logic I added. |
This PR fixes the version dropdown