Handle integer overflows and other stuff #1619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shssoichiro
reviewed
Aug 30, 2019
shssoichiro
reviewed
Aug 30, 2019
lu-zero
reviewed
Aug 31, 2019
Collaborator
lu-zero
left a comment
There was a problem hiding this comment.
I can try to prepare a little more structured errors so we could hint what's wrong and what's the correct value-range. Ideally we could move all the validation in a function like:
Config::validate() ->Result<(), ConfigError>
and call it inside the Context factory.
For use in tests.
Collaborator
Author
|
Fixed, rebased, etc. |
lu-zero
approved these changes
Sep 3, 2019
Collaborator
lu-zero
left a comment
There was a problem hiding this comment.
It is a good step in the right direction, some refactoring and considerations may happen later.
|
|
||
| impl Sequence { | ||
| pub fn new(config: &EncoderConfig) -> Sequence { | ||
| pub fn new(config: &EncoderConfig) -> Option<Sequence> { |
Collaborator
There was a problem hiding this comment.
I'd keep the assert and move the check (using ilog maybe) where the configuration is validated. The sequence is an internal detail and should never fail no matter the input.
Collaborator
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fuzzed things. Things broke.
Fixes #1616.
This changes the type of
rdo_lookahead_framesinEncoderConfigfromu64tousize. API change; merge this before 0.1 if possible?