Fix an LRF crash when encoding tiny frames #1797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Another option would be to disable lrf for images smaller than something. I doubt it would have a beneficial impact if any. |
Collaborator
This fixes a crash in LRF at widths or heights of 1 px as a side effect of disabling restoration at sizes where it is not likely to improve quality.
Collaborator
Author
|
@lu-zero I updated the PR with this solution and added an assertion when initializing the restoration context. |
tdaede
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while fuzzing and took the easy way out. An alternative or complementary solution would be to assert that the frame size is valid and display a proper error message if it is not (I could not find the minimum frame size requirements in the spec, but I seem to recall they exist).