ci: Update supported GHC versions #694
Conversation
+ Prefer GHC 8.10.7 to 8.10.4, as versions seem to have stabilised now. + Add support for Stackage LTS 19, which ships with GHC 9.0.2. + Since a new version of 9.2 has been released, prefer 9.2.2 over 9.2.1. Related: xmonad/xmonad-contrib#694
| yaml: stack-master.yaml | ||
| - resolver: lts-19 | ||
| ghc: 9.0.2 | ||
| yaml: stack-master.yaml |
There was a problem hiding this comment.
Is this intentionally duplicated?
I should've added a comment back then about the stack/stack-master stuff: we primarily test using stack-master (uses X11, xmonad master) but we also want to make sure that it works with the latest X11, xmonad releases so we do that with the most and least recent LTS, just to make the test matrix a bit smaller (and thus less likely to hit github limits).
There was a problem hiding this comment.
Whoops, not at all! Forgot to stack-master.yaml -> stack.yaml there
|
I'm a bit confused about why the hlint issue was not a problem before. Can anyone help me understand that? Otherwise this looks all right apart from the one issue in the stack workflow. |
It seems like the bug only fires when |
Oh, I see. I was looking at the wrong diff. Will give it some more thought once I get back from pub :-) |
|
@liskin got any insights from the beer? :) |
+ Prefer GHC 8.10.7 to 8.10.4, as versions seem to have stabilised now. + Add support for Stackage LTS 19, which ships with GHC 9.0.2. + Since a new version of 9.2 has been released, prefer 9.2.2 over 9.2.1. Also, explicitly pass -XCPP to hlint; see [1]. [1]: ndmitchell/hlint#1360
No real insights. I set a reminder for myself to check/drop the hlint patch in 2 months time (kinda hoped the fix would have been released by now) and forcepushed the stack.yaml fixes. Feel free to proceed with other repos, and sorry for the delay. |
+ Prefer GHC 8.10.7 to 8.10.4, as versions seem to have stabilised now. + Add support for Stackage LTS 19; this ships with GHC 9.0.2. + Since a new version of 9.2 has been released, prefer 9.2.2 over 9.2.1. Related: xmonad/xmonad-contrib#694
+ Prefer GHC 8.10.7 to 8.10.4, as versions seem to have stabilised now. + Add support for Stackage LTS 19; this ships with GHC 9.0.2. + Since a new version of 9.2 has been released, prefer 9.2.2 over 9.2.1. Related: xmonad/xmonad-contrib#694 Related: xmonad/xmonad@a854cda
+ Prefer GHC 8.10.7 to 8.10.4, as versions seem to have stabilised now. + Add support for Stackage LTS 19; this ships with GHC 9.0.2. + Since a new version of 9.2 has been released, prefer 9.2.2 over 9.2.1. Related: xmonad/xmonad-contrib#694 Related: xmonad/xmonad@a854cda Related: xmonad/xmonad-X11@bbc04982ecf9f36c2c706b2bb13c9b96a052aa19
+ Prefer GHC 8.10.7 to 8.10.4, as versions seem to have stabilised now. + Add support for Stackage LTS 19; this ships with GHC 9.0.2. + Since a new version of 9.2 has been released, prefer 9.2.2 over 9.2.1. Related: xmonad/xmonad-contrib#694
NOTE: I will prepare the same thing for the
xmonadrepo, but don't want to create too much noise with PRs. After this is rubber-stamped I will just push it directly.Description
Also, explicitly pass -XCPP to hlint; see 1.
Checklist
I've read CONTRIBUTING.md
I've considered how to best test these changes (property, unit,
manually, ...) and concluded: CI passes
[n/a] I updated the
CHANGES.mdfile