Thanks to visit codestin.com
Credit goes to github.com

Skip to content

write changelog for v1.0.1 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xhuw merged 2 commits into from
Oct 3, 2023
Merged

write changelog for v1.0.1 #24

xhuw merged 2 commits into from
Oct 3, 2023

Conversation

@xhuw
Copy link
Contributor

@xhuw xhuw commented Oct 3, 2023

The described change is already on main but the release wasn't done #21 . This PR updates the changelog to prepare for v1.0.1

@xhuw xhuw requested review from mbanth and xluciano October 3, 2023 09:54
xluciano
xluciano reviewed Oct 3, 2023
View reviewed changes
Copy link

@xluciano xluciano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I have two questions:

  1. do we need #23?
    2. Can we update xmos_cmake_toolchain too? The version in use is old and untagged.

@xhuw
Copy link
Contributor Author

xhuw commented Oct 3, 2023

The changes look good. I have two questions:

1. do we need [Add MINIMISE_MAIN_TILE_ARGS define in tile_map.xc  #23](https://github.com/xmos/fwk_core/pull/23)?
   2. Can we update `xmos_cmake_toolchain` too? The version in use is old and untagged.
  1. no, that is WIP and we can make another release when it is ready
  2. will do

@mbanth mbanth assigned xhuw and unassigned mbanth Oct 3, 2023
@xhuw xhuw merged commit 16e1dcd into develop Oct 3, 2023
@xhuw xhuw deleted the feature/prepare-for-v1.0.1 branch October 3, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbanth mbanth mbanth approved these changes

+1 more reviewer

@xluciano xluciano xluciano left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@xhuw xhuw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xhuw @xluciano @mbanth