Merge v1.0.2 staging to main #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will need to update xcore_math submodule
…t/fwk_core into feature/doc_builder_v4
Feature/doc builder v4
# Conflicts: # settings.json
mbanth
requested changes
Oct 23, 2023
xluciano
approved these changes
Oct 23, 2023
xluciano
left a comment
There was a problem hiding this comment.
Just one comment. I may have misunderstood how xmosdoc v4 works, but I think we can remove the settings.json file.
mbanth
requested changes
Oct 23, 2023
mbanth
approved these changes
Oct 24, 2023
xluciano
approved these changes
Oct 24, 2023
xluciano
left a comment
There was a problem hiding this comment.
Looks good to me, I have only one optional comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.