Ensure we flash a specific xtag id in hil_add test#178
Merged
keithm-xmos merged 2 commits intoxmos:developfrom May 18, 2023
Merged
Ensure we flash a specific xtag id in hil_add test#178keithm-xmos merged 2 commits intoxmos:developfrom
keithm-xmos merged 2 commits intoxmos:developfrom
Conversation
Contributor
Author
|
So it looks like we're back to the intermittent failure seen when the test runs 1 min quicker and the |
Contributor
|
Sadly this did not address this issue. But, we do want this merged as it corrects the missing adapter ID. |
Contributor
|
Mentioning @johnshaferXMOS so he is aware of this fix. He is investigating the test crash. I've entered this new issue to track this: #179 |
keithm-xmos
approved these changes
May 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
introduced in #172
Hopefully will bring Jenkins back to green.