Fixing hfilter unit test #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
@uvvpavel
The tests are working fine.
Besides that, I would prefer to have a more simple use case where we just compare for example:
hfilter_state_t state[N];
hfilter_state_t expected_state[N];
then a for loop that checks all the cases.
But it is not urgent, we can either take a bit of time now or backlog for the next release.
Let me know your thoughts to approve or not.
xalbertoisorna
approved these changes
Jun 21, 2023
xalbertoisorna
added a commit
that referenced
this pull request
Jun 29, 2023
merging develop to fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of