Add Welcome Metadata #278
Merged
Add Welcome Metadata #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
approved these changes
Jun 30, 2025
Contributor
|
Will this cause issues since the migration already ran for it? |
Contributor
Author
|
It shouldn't, the migration that uses it will be dropped on the next deploy and it wasn't used anywhere. The Node go PR is on this branch and passes all tests. |
|
🎉 This PR is included in version 3.84.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add welcome metadata by restructuring WelcomeMessage.V1 and WelcomeMessageInput.V1 to use WelcomeMetadata message for message cursor field in MLS protocol buffer definition
The MLS protocol buffer definition restructures how message cursors are handled in welcome messages by moving the
message_cursorfield from direct inclusion inWelcomeMessage.V1andWelcomeMessageInput.V1to a newWelcomeMetadatamessage structure. The changes modify field 7 inWelcomeMessage.V1fromuint64 message_cursortobytes welcome_metadata, updateWelcomeMessageInput.V1by changing field 5 fromuint64 message_cursortobytes welcome_metadataat field 7, and introduce the newWelcomeMetadatamessage containing theuint64 message_cursorfield that gets encrypted alongside the data field. See mls.proto.📍Where to Start
Start with the
WelcomeMessage.V1structure definition in mls.proto to understand the field changes frommessage_cursortowelcome_metadata.Macroscope summarized 77ac713.