Update settlement flows #1081
Closed
Update settlement flows #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Sep 2, 2025
Closed
Implement settlement processing to update settlement flows by handling
|
adfa4a7 to
5a6cb7a
Compare
272c758 to
1f038a2
Compare
5a6cb7a to
6c57b83
Compare
6c57b83 to
a8812eb
Compare
1f038a2 to
89d2900
Compare
a8812eb to
435894f
Compare
89d2900 to
70dbe40
Compare
435894f to
b28fced
Compare
70dbe40 to
8e325f2
Compare
b28fced to
92de60f
Compare
8e325f2 to
85d4ef5
Compare
92de60f to
e2bc145
Compare
mkysel
approved these changes
Sep 2, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Sep 2, 2025
### TL;DR
Refactored payer report status management and added functionality to clear unsettled usage when reports are settled.
### What changed?
- Added a new `ClearUnsettledUsage` SQL query to delete unsettled usage records for an originator up to a specific time
- Added a `FetchPayerReport` query to retrieve a single payer report by ID
- Replaced string manipulation in SQL queries with proper PostgreSQL array parameters using `pq.Array`
- Simplified the report status management API by replacing generic status transition methods with specific, purpose-named methods:
- `SetReportSubmitted`
- `SetReportSettled`
- `SetReportAttestationApproved`
- `SetReportAttestationRejected`
- Implemented the `PayerReportSubsetSettled` event handler to properly mark reports as settled and clear associated unsettled usage
- Added comprehensive tests for the new settlement functionality
### How to test?
1. Create a payer report with unsettled usage
2. Call `SetReportSettled` on the report
3. Verify that:
- The report status changes to `SubmissionSettled`
- Unsettled usage records for that originator up to the report's end minute are cleared
- Unsettled usage records after the end minute remain intact
- Unsettled usage for other originators is not affected
### Why make this change?
This change improves the settlement process by automatically clearing unsettled usage records once a report is settled on-chain. This prevents double-counting of usage in future reports and maintains data integrity. The refactored API also makes the code more maintainable by providing clear, purpose-specific methods for state transitions rather than generic methods that could be misused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Refactored payer report status management and added functionality to clear unsettled usage when reports are settled.
What changed?
ClearUnsettledUsageSQL query to delete unsettled usage records for an originator up to a specific timeFetchPayerReportquery to retrieve a single payer report by IDpq.ArraySetReportSubmittedSetReportSettledSetReportAttestationApprovedSetReportAttestationRejectedPayerReportSubsetSettledevent handler to properly mark reports as settled and clear associated unsettled usageHow to test?
SetReportSettledon the reportSubmissionSettledWhy make this change?
This change improves the settlement process by automatically clearing unsettled usage records once a report is settled on-chain. This prevents double-counting of usage in future reports and maintains data integrity. The refactored API also makes the code more maintainable by providing clear, purpose-specific methods for state transitions rather than generic methods that could be misused.