Fix enums including whitespace #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xnuinside
approved these changes
Jan 18, 2026
xnuinside
added a commit
that referenced
this pull request
Jan 18, 2026
Update test assertions to match the functional Enum format introduced in PR #69. The new enum template generates: Status = Enum(value='Status', names=[...]) Instead of the previous class-based syntax: class Status(str, Enum): Tests updated: - test_from_pydantic_to_dataclass - test_pydantic_v2_enums
xnuinside
added a commit
that referenced
this pull request
Jan 18, 2026
Update test assertions to match the functional Enum format introduced in PR #69. The new enum template generates: Status = Enum(value='Status', names=[...]) Instead of the previous class-based syntax: class Status(str, Enum): Tests updated: - test_from_pydantic_to_dataclass - test_pydantic_v2_enums
Owner
|
thanks for the pr, sorry for the long delay, have no time at all on open source :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current class-based enum definition yields invalid Python syntax when enums include whitespace
This PR changes the output of enums using the functional API that allows us to specify the member names using tuple lists or dicts. This way we can use names with spaces:
All tests are passing and updated to the new enum syntax.
Fixes #68