Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

murfffi
Copy link
Contributor

@murfffi murfffi commented Dec 7, 2024

testcli.go failed before the fix and passes after it.
Also includes a fix to testcli.go itself.

Closes #505 .

@murfffi murfffi marked this pull request as draft December 7, 2024 11:45
@murfffi murfffi force-pushed the fix/testcli-postgres branch 3 times, most recently from d25078b to 8c5c3b8 Compare December 7, 2024 12:42
@murfffi murfffi mentioned this pull request Dec 7, 2024
@murfffi murfffi force-pushed the fix/testcli-postgres branch from 8c5c3b8 to 066926f Compare December 17, 2024 06:48
@murfffi murfffi changed the title draft: Test if the line in contrib/postgres/test.sql is the culprit Fix substitution of quoted variables Dec 17, 2024
@murfffi murfffi force-pushed the fix/testcli-postgres branch from 066926f to 779bef2 Compare December 17, 2024 07:03
@murfffi
Copy link
Contributor Author

murfffi commented Dec 17, 2024

Please advise if a new unit test is needed here. stmt_test.go contains tests for statement parsing (TestNextResetState) and substitution (TestVarSubstitute) but I didn't see a test for both at the same time. (I might have missed it - there are a lot of tests.)

Maybe this is where testcli.go comes in, though it took me some time to get from its failure to the root cause.

@murfffi murfffi marked this pull request as ready for review December 17, 2024 07:10
testcli.go failed before the fix and passes after it.
Also includes a fix to testcli.go itself.
@murfffi murfffi force-pushed the fix/testcli-postgres branch from 779bef2 to b37c28b Compare December 17, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

regression: quoted variables replacement doesn't work on master

2 participants