Use get-tsconfig for ts matching #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that our logic was having some issues with nested tsconfigs
So this PR:
uses
getTsconfigfor every file, due to lots of internal caching this appears to be very fast still and behaves much more like ts lang server does by finding the nearest tsconfig.json rather than just looking in the root.uses get-tsconfigs file matcher which is much more accurate than our custom logic based on micromatch.
We no longer attempt to re-use any of the users tsconfigs if they are matched, we only write our own default tsconfig for unmatched files. This should provide a more consistent xo experience.
Added a few tests for nested configs and edge cases.