Add .NET 9 target, drop .NET 6 #828
Merged
+14
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihaZupan
commented
Nov 30, 2024
| build: | ||
| uses: xoofx/.github/.github/workflows/dotnet.yml@main | ||
| with: | ||
| dotnet-version: '6.0 8.0' |
Collaborator
Author
There was a problem hiding this comment.
Passing dotnet-version: '6.0 8.0 9.0' to the setup-dotnet action ends up building the latest LTS + the first item in the list.
With 6.0 8.0 that just happens to (currently) match the intended result.
Owner
|
Thanks! |
Contributor
|
This is nice. But those whose projects are targeting .NET 6 will now receive a bonus with the updates, in a form of .NET Standard 2.1 DLL that misses some features of the .NET versions, like locals init switched off, and everything that depends on the "NET" condition. |
Collaborator
Author
|
Such projects should likely focus on moving to a supported .NET runtime before updating their Markdig version then, especially if performance is a concern |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike in the past, there is now a reason to bump TFMs even when not explicitly using new APIs due to language changes that can target better overloads when recompiling (e.g.
params spanorOverloadResolutionPriority).I don't know of any places where that would kick in for Markdig right now, but there are some neat new APIs in 9.0 that might be interesting to play with here.
I've also added back older TFMs to the test project so we're not completely without coverage (given we have a bit of conditionally-compiled code & polyfills). Skipped framework though cuz CI was being weird 🤷♂️
Some initial numbers without any Markdig changes on a large document (.NET 9 perf blog post ~570 KB):