Open
Conversation
added 4 commits
January 31, 2014 14:43
…about pushing this up as a pull request. Sorry. First: require paths were done in a non-standard way. They should still work as they had, but they follow the more traditional way of prefixing everything with the library name. There are other ways to tighten this up, but this method didn't touch the structure. Second, unpack was moved to table.unpack, so I added that. Lastly, I made sleep more modular, adding support for windows and also for my lsleep library. It's transparent to the user, so it shouldn't be a problem.
Owner
|
Cant merge this from the web interface (claims some conflict), will look into it later |
Contributor
Author
|
Yeah. This is because I included the idle code in some other commit. Sorry about that. I'll sync my master with yours, remove idle.lua and then merge the branch into it. |
Contributor
Author
|
Yeah. I tried to do this in some sort of "right way." In short, keep the changes in idle.lua that are in this commit. As I said, I added the old file to every commit, by accident. :( |
|
ok, I found the bug creator here 🎱 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added check for windows and sleep method for it, if found.
Also, I have a tiny C library that just does sleep. It also works for unix/mac/windows and support usleep, as well as sleep. I added some commented-out code that you can add in, if you wish to support it. I thought it was presumptuous of me to do so. :)