This repository was archived by the owner on Apr 22, 2025. It is now read-only.
Preliminary Array Insertion #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes y-crdt#126 `YArray.extend` works with preliminary YTypes once again! ## Changes - Updated `YArray::insert_multiple_at` to correctly check for preliminary types and gracefully handle errors. ## Testing - Updated `test_inserts` in test_y_array.py to ensure insertions and extensions work with preliminary types.
dmonad
approved these changes
Mar 15, 2023
davidbrochart
approved these changes
Mar 15, 2023
Collaborator
davidbrochart
left a comment
There was a problem hiding this comment.
Thanks @Waidhoferj !
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126
YArray.extendworks with preliminary YTypes once again!Changes
YArray::insert_multiple_atto correctly check for preliminary types and gracefully handle errors.Testing
test_insertsin test_y_array.py to ensure insertions and extensions work with preliminary types.