Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix type def of decodeFromImage() param #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2022
Merged

Fix type def of decodeFromImage() param #23

merged 1 commit into from
Nov 23, 2022

Conversation

@dyoshikawa
Copy link
Contributor

@dyoshikawa dyoshikawa commented Nov 23, 2022 •
edited
Loading

The decodeFromImage() function accepts a string type as an argument. And this works as expected. However, when use TypeScript, actually setting the string type causes a type definition error.

Example:

const qrCodeBase64Str = 'data:image/png;base64...'
const qrCodeDecoder = new QrCodeDecoder()
qrCodeDecoder.decodeFromImage(qrCodeBase64Str).then((result) => console.log(result))
// => Error: "Argument of type 'string' is not assignable to parameter of type 'HTMLImageElement'."

This PR prevents the type definition error from occurring.

@yugasun yugasun merged commit 0b7edb3 into yugasun:master Nov 23, 2022
@dyoshikawa dyoshikawa deleted the fix-type-def-of-decode-from-image-param branch November 23, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dyoshikawa @yugasun