feat: mcap support #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5b29f11 to
31e54fc
Compare
sandhawalia
reviewed
Sep 23, 2024
Contributor
|
successfully build the package and ran visualization with carla/yaak/mcap_protobuf. 💪🏽 |
sandhawalia
reviewed
Sep 23, 2024
sandhawalia
reviewed
Sep 23, 2024
sandhawalia
approved these changes
Sep 23, 2024
Contributor
sandhawalia
left a comment
There was a problem hiding this comment.
Some minor comments. Otherwise LGTM. Build locally and tested it.
31e54fc to
b84a2ea
Compare
- add mcap readers (protobuf/ros2) - abstract tabular source processing - slimmer configs - add `read-frames` script
b84a2ea to
d9e1278
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read-framesscriptcloses #1