Thanks to visit codestin.com
Credit goes to github.com

Skip to content

diable secureCrudApi for now #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
basejump merged 1 commit into from
May 2, 2025
Merged

diable secureCrudApi for now #891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions examples/rally-api/src/integration-test/groovy/yakworks/rest/OrgRestApiSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import okhttp3.Request
import okhttp3.RequestBody
import org.apache.poi.xssf.usermodel.XSSFWorkbook
import org.springframework.http.HttpStatus

import spock.lang.Ignore
import spock.lang.IgnoreRest
import yakworks.rest.client.OkAuth
import yakworks.rest.client.OkHttpRestTrait
Expand Down Expand Up @@ -416,6 +418,9 @@ class OrgRestApiSpec extends Specification implements OkHttpRestTrait, WithTrx {
body.detail.contains "expecting '}'"
}

//XXX @SUD turn back on when secureCrudApi is sorted out
// is this the only test we have?
@Ignore
void "test readonly operation"() {
setup:
OkAuth.TOKEN = null
Expand Down
9 changes: 7 additions & 2 deletions gorm-rest/src/main/groovy/yakworks/rest/gorm/controller/CrudApiController.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import gorm.tools.beans.Pager
import gorm.tools.job.SyncJobEntity
import gorm.tools.problem.ProblemHandler
import gorm.tools.repository.model.DataOp
import gorm.tools.utils.ServiceLookup
import grails.web.Action
import yakworks.api.problem.Problem
import yakworks.etl.csv.CsvToMapTransformer
Expand Down Expand Up @@ -93,10 +94,14 @@ trait CrudApiController<D> extends RestApiController {

CrudApi<D> getCrudApi(){
if (!crudApi) {

//XXX future secureCrudApi, should be able to be turned on and off with config
//not using ServiceLookup.lookup as we dont want to inject OrgCrudApi, even if its available,
//Always inject SecureCrudApi, which wraps and delegates to configured custom CrudApi or DefaultCrudApi.
this.crudApi = (CrudApi<D>)AppCtx.ctx.getBean("secureCrudApi", [getEntityClass()] as Object[])
//this.crudApi = ServiceLookup.lookup(getEntityClass(), CrudApi<D>, "secureCrudApi")
//this.crudApi = (CrudApi<D>)AppCtx.ctx.getBean("secureCrudApi", [getEntityClass()] as Object[])

this.crudApi = ServiceLookup.lookup(getEntityClass(), CrudApi<D>, "secureCrudApi")

//this.crudApi = crudApiFactory.apply(getEntityClass())
//this.crudApi = crudApiClosure.call(getEntityClass()) as CrudApi<D>
// try {
Expand Down
1 change: 1 addition & 0 deletions gorm-rest/src/main/groovy/yakworks/rest/gorm/mapping/RepoApiMappingsService.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ class RepoApiMappingsService {
.httpMethod('PUT').action('bulkUpdate').suffix('/bulk')
.urlMappingBuilder(builderDelegate).build()

//XXX @SUD, what this mean "not working, doesnt get picked up"?
//bulk export FIXME @SUD, not working, doesnt get picked up
SimpleUrlMappingBuilder.of(contextPath, nspace, ctrlName)
.httpMethod('GET').action('bulkExport').suffix('/bulk')
Expand Down