Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove DefaultSecurityConfiguration.addJsonAuthenticationFilter #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
basejump merged 1 commit into from
Jun 13, 2025
Merged

remove DefaultSecurityConfiguration.addJsonAuthenticationFilter #907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...ly-api/src/integration-test/groovy/yakworks/security/JsonUsernamePasswordLoginSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,15 @@ package yakworks.security
import grails.testing.mixin.integration.Integration
import okhttp3.Request
import okhttp3.Response
import spock.lang.Ignore
import spock.lang.Specification

import yakworks.rest.client.OkHttpRestTrait

/**
* test the legacy login with post username and password to login endpoint.
*/
@Ignore
@Integration
class JsonUsernamePasswordLoginSpec extends Specification implements OkHttpRestTrait {

Expand Down
2 changes: 2 additions & 0 deletions examples/rally-api/src/integration-test/groovy/yakworks/security/OpaqueRestApiSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import org.springframework.http.HttpStatus
import org.springframework.security.oauth2.core.OAuth2AccessToken

import grails.testing.mixin.integration.Integration
import spock.lang.Ignore
import spock.lang.Specification

import yakworks.rest.client.OkAuth
Expand All @@ -16,6 +17,7 @@ import yakworks.security.spring.token.store.TokenStore

import java.time.ZoneId

@Ignore
@Integration
class OpaqueRestApiSpec extends Specification implements OkHttpRestTrait {

Expand Down
5 changes: 3 additions & 2 deletions examples/rally-api/src/main/groovy/yakworks/rally/boot/RallyApiSpringConfig.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,9 @@ class RallyApiSpringConfig {

http.oauth2Login(withDefaults())

//tokenLegacy for using username/password json in api/login, forwards to api/tokenLegacy which saves random string in db as token
DefaultSecurityConfiguration.addJsonAuthenticationFilter(http, tokenStore)
// Legacy tokenLegacy for using username/password json in api/login, forwards to api/tokenLegacy which saves random string in db as token
// DefaultSecurityConfiguration.addJsonAuthenticationFilter(http, tokenStore)

//enables jwt and oauth
DefaultSecurityConfiguration.applyOauthJwt(http)

Expand Down
5 changes: 4 additions & 1 deletion gorm-tools/src/main/groovy/gorm/tools/repository/GormRepo.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,12 +475,15 @@ trait GormRepo<D> implements ApiCrudRepo<D>, BulkableRepo<D>, ResolvableTypeProv

/**
* wraps get in a trx, usefull for testing. NOT a read only trx like read as that messes with dirty tracking
* Throws NotFoundExeption if null
* @param id the id to get
* @return the retrieved entity
*/
D getWithTrx(Serializable id) {
withTrx {
return (D)gormStaticApi().get(id)
var instance = (D)gormStaticApi().get(id)
RepoUtil.checkFound(instance, id, getEntityClass().simpleName)
return instance
}
}

Expand Down
7 changes: 6 additions & 1 deletion rally-domain/src/main/groovy/yakworks/rally/extensions/UserInfoExt.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,12 @@ class UserInfoExt {
@NullCheck
static Org getOrg(UserInfo userInfo){
Validate.notNull(userInfo.orgId, "userInfo.orgId is null for user:[id:${userInfo.id}, username: ${userInfo.username}]")
return Org.repo.getWithTrx(userInfo.orgId)
try {
return Org.repo.getWithTrx(userInfo.orgId)
} catch(e) {
return null
}

}

static boolean isCustomer(UserInfo self){
Expand Down