Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Dec 20, 2022. It is now read-only.

Conversation

@WindzCUHK
Copy link
Contributor

@WindzCUHK WindzCUHK commented Sep 27, 2022

Description

add resource prefix config

  • old spec
https://host1/secret -> sidecar (resourcePrefix: "") -> resources: /secret -> ❌
https://host2/secret -> sidecar (resourcePrefix: "") -> resources: /secret -> ❌
  • new spec
https://host1/secret -> sidecar (resourcePrefix: "/private") -> resources: /private/secret -> ❌
https://host2/secret -> sidecar (resourcePrefix: "/public") -> resources: /public/secret -> ✅

Type of change

  • Bug fix
  • New feature
  • Refactoring (no functional changes, no api changes)
  • Non-code changes (update documentation, pipeline, etc.)

Flags

  • breaks backward compatibility
  • requires a documentation update
  • has untestable code

Related issue/PR


Checklist

  • Followed the guidelines in the CONTRIBUTING document
  • Added prefix [major]/[minor]/[patch]/[skip] in the PR title
  • Tested and linted the code
  • Commented the code
  • Made corresponding changes to the documentation
  • Confirmed no dropping in test coverage (by Codecov)
  • Passed all pipeline checking
  • Approved by >1 reviewer

Checklist for maintainer

  • Use Squash and merge
  • Double-confirm the merge message has prefix [major]/[minor]/[patch]/[skip]
  • Delete the branch after merge

@WindzCUHK WindzCUHK merged commit 028db59 into master Sep 28, 2022
@WindzCUHK WindzCUHK deleted the add-resource-prefix branch September 28, 2022 07:19
WindzCUHK added a commit that referenced this pull request Oct 3, 2022
@WindzCUHK WindzCUHK restored the add-resource-prefix branch October 3, 2022 08:17
WindzCUHK added a commit that referenced this pull request Oct 3, 2022
* add force content length

* add unit test

* fix comment

* Revert "[minor] add resource prefix config (#97)"

This reverts commit 028db59.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants