fix(htmx): added ext/htmx.js library #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request introduces the Sequence diagram for serving htmx.js with ETag cachingsequenceDiagram
participant Browser
participant Server
Browser->>Server: GET htmx.js
Server->>Server: Compute ETag for htmx.js
Server->>Server: Check If-None-Match header
alt If-None-Match matches ETag
Server-->>Browser: 304 Not Modified
else If-None-Match does not match ETag
Server-->>Browser: 200 OK with htmx.js and ETag
end
Class diagram for FileViewer changesclassDiagram
class FileViewer {
-fsys fs.FS
-path string
-isEmbed bool
-etag string
+NewFileViewer(fsys fs.FS, path string, isEmbed bool) *FileViewer
+Render(ctx *Context, data any) error
-serveContent(w http.ResponseWriter, r *http.Request) error
}
note for FileViewer "ETag is now computed using ComputeETag function"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Hey @cnlangzi - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment to the
HandleFuncinhtmx.goexplaining what the javascript code does. - It looks like you've extracted the etag logic into
etag.go- consider renaming this toetag_utils.goor similar to indicate that it's a utility file.
Here's what I looked at during the review
- π‘ General issues: 1 issue found
- π’ Security: all looks good
- π’ Testing: all looks good
- π‘ Complexity: 2 issues found
- π’ Documentation: all looks good
Help me be more useful! Please click π or π on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 94.13% 94.35% +0.21%
==========================================
Files 54 55 +1
Lines 2200 2284 +84
==========================================
+ Hits 2071 2155 +84
Misses 96 96
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. |
|
@sourcery-ai review |
There was a problem hiding this comment.
Hey @cnlangzi - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting the common ETag logic into a shared utility function to reduce code duplication.
- The
loadJavaScriptfunction is duplicated in both thehtmxandcsrfextensions; can this be moved to a common utility?
Here's what I looked at during the review
- π’ General issues: all looks good
- π’ Security: all looks good
- π’ Testing: all looks good
- π’ Complexity: all looks good
- π’ Documentation: all looks good
Help me be more useful! Please click π or π on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Fixed
Added
htmx.jslibraries to help htmx development.Tests
Tasks to complete before merging PR:
make unit-testto check for any regressions πmake lintto check for any issuesSummary by Sourcery
This pull request adds the
htmx.jslibrary and enhances caching for HTMX and CSRF JavaScript files by implementing ETag support. It also includes a new$x.ready()function that executes callbacks when the DOM is loaded or when anhtmx:loadevent occurs.New Features:
htmx.jslibrary to provide client-side support for HTMX development, including a$x.ready()function that executes callbacks when the DOM is loaded or when anhtmx:loadevent occurs.Enhancements:
Tests:
htmx.jslibrary correctly and returns a 304 status code when the ETag matches.