Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(json): use std json instead of json-iterator to support omitzero #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 21, 2025
Merged

fix(json): use std json instead of json-iterator to support omitzero #54

merged 4 commits into from
Feb 21, 2025

Conversation

cnlangzi
Copy link
Member

@cnlangzi cnlangzi commented Feb 21, 2025 •
edited by sourcery-ai bot
Loading

Changed

Fixed

  • fix(json): use std json instead of json-iterator to support omitzero

Added

Tests

Tasks to complete before merging PR:

  • Ensure unit tests are passing. If not run make unit-test to check for any regressions πŸ“‹
  • Ensure lint tests are passing. if not run make lint to check for any issues
  • Ensure codecov/patch is passing for changes.

Summary by Sourcery

This pull request replaces the json-iterator library with the standard encoding/json package to enable the omitempty option for JSON serialization. It also updates the code to use the standard encoding/json package and removes the json-iterator dependency.

Bug Fixes:

  • Replaces the json-iterator library with the standard encoding/json package to enable the omitempty option for JSON serialization.

Enhancements:

  • Updates the code to use the standard encoding/json package instead of json-iterator.

Chores:

  • Removes the json-iterator dependency.

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 21, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request replaces the json-iterator library with the standard encoding/json library to support omitempty and fixes a javascript example in README.md.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Replaced the json-iterator library with the standard encoding/json library.
  • Removed the json-iterator dependency.
  • Replaced all instances of jsoniter with encoding/json.
  • Added a JsonEncoding interface to abstract the JSON encoding/decoding implementation.
  • Created a stdJsonEncoding struct that implements the JsonEncoding interface using the standard encoding/json library.
  • Initialized a global Json variable with an instance of stdJsonEncoding.
 app_test.go
context.go
routing_option_test.go
context_test.go
ext/form/binder.go
ext/htmx/htmx.go
go.mod
compressor_deflate_test.go
compressor_gzip_test.go
viewengine_text_test.go
viewer_json.go
json.go
Modified the javascript example in README.md
  • Changed document.body.addEventListener to document.addEventListener
  • Removed the 'body' argument from xun.ready
 README.md
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepsource-io
Copy link

deepsource-io bot commented Feb 21, 2025 •
edited
Loading

Here's the code health analysis summary for commits d22caf2..e503b4d. View details on DeepSourceΒ β†—.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGoβœ…Β SuccessView CheckΒ β†—
πŸ’‘ If you’re a repository administrator, you can configure the quality gates from the settings.

sourcery-ai[bot]
sourcery-ai bot reviewed Feb 21, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cnlangzi - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment explaining why the json-iterator library was replaced with the standard library.
  • It looks like you've replaced all instances of json with Json, but you should define Json in a single place to avoid confusion.
Here's what I looked at during the review
  • 🟒 General issues: all looks good
  • 🟒 Security: all looks good
  • 🟒 Testing: all looks good
  • 🟒 Complexity: all looks good
  • 🟒 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click πŸ‘ or πŸ‘Ž on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 94.36%. Comparing base (d22caf2) to head (e503b4d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   94.35%   94.36%   +0.01%     
==========================================
  Files          55       56       +1     
  Lines        2284     2291       +7     
==========================================
+ Hits         2155     2162       +7     
  Misses         96       96              
  Partials       33       33
Flag Coverage Ξ”
Unit-Tests 94.36% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@cnlangzi cnlangzi merged commit 8ede36c into main Feb 21, 2025
8 checks passed
@cnlangzi cnlangzi deleted the fix/json branch February 21, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cnlangzi