fix(htmx): added fetch wrapper to support Hx-Trigger feature like htmx request
#56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request introduces a wrapper around the native Sequence diagram for fetch wrapper with Hx-Trigger supportsequenceDiagram
participant Browser
participant fetchWrapper as $x.fetch
participant Server
participant CustomEventDispatcher
Browser->>fetchWrapper: fetch(url, options)
fetchWrapper->>Server: HTTP Request
Server-->>fetchWrapper: HTTP Response (with Hx-Trigger header)
alt Hx-Trigger header exists
fetchWrapper->>CustomEventDispatcher: Parse Hx-Trigger
loop For each trigger in Hx-Trigger
CustomEventDispatcher->>Browser: dispatchEvent(CustomEvent(trigger))
end
end
fetchWrapper-->>Browser: Response
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Here's the code health analysis summary for commits Analysis Summary
|
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
=======================================
Coverage 94.27% 94.27%
=======================================
Files 56 56
Lines 2305 2305
=======================================
Hits 2173 2173
Misses 98 98
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Hey @cnlangzi - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a more descriptive name than
$xfor the global object. - The
fetchwrapper could be simplified by usingresponse.headers.forEachinstead of manually iterating over the keys.
Here's what I looked at during the review
- π‘ General issues: 1 issue found
- π’ Security: all looks good
- π’ Testing: all looks good
- π’ Complexity: all looks good
- π’ Documentation: all looks good
Help me be more useful! Please click π or π on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Fixed
Added
Tests
Tasks to complete before merging PR:
make unit-testto check for any regressions πmake lintto check for any issuesSummary by Sourcery
This pull request introduces a
fetchwrapper to support theHx-Triggerfeature, enabling server-sent events to trigger client-side actions like HTMX requests. It also renames the global object fromxunto$x.New Features:
fetchfunction to support theHx-Triggerheader, allowing server-sent events to trigger client-side actions similar to HTMX requests.Enhancements:
xunto$x.